Add optional preventInitialBackfill for SLO API #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will address #1070 |
kdelemme
reviewed
Mar 21, 2025
I think the generated settings model found at generated/slo/model_settings.go is still missing a final component here, but that file is generated by OpenAPI so we probably have a change to make in our open API docs, or we need to re-run the generation script there?
tobio
force-pushed
the
add-slo-preventBackfill
branch
from
9ae4605 to
49e39ec
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tobio
approved these changes
Sep 16, 2025
@jasonrhodes I updated the client in #1303 |
wandergeek
approved these changes
Sep 16, 2025
tobio
added a commit
that referenced
this pull request
Sep 23, 2025
* origin/main: fix: nil reference in api.kibana_synthetics.go:418 in case of unmarshable arrays (#1320) Bump github.com/hashicorp/terraform-plugin-framework (#1326) Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.37.0 to 2.38.0 (#1325) chore(deps): update golang:1.25.1 docker digest to 8305f5f (#1322) Clarify how acceptance tests should be run (#1324) Move diag utilities from utils to dedicated diagutil package (#1317) Add support for Kafka Fleet output types. (#1302) Allow a default for `allow_restricted_indices` within an API Key role descriptor (#1315) Improve docs generation (#1313) Add optional preventInitialBackfill for SLO API (#1071) Add support for dataViewId (#1305) [Feature] Add unenrollment_timeout parameter to Fleet Agent Policy resource (#1306) chore(deps): update actions/setup-go action to v6 (#1301) chore(deps): update golang docker tag to v1.25.1 (#1300) Update generated SLO client. (#1303)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1070
Docs for this option are here: https://www.elastic.co/docs/api/doc/serverless/operation/operation-createsloop#operation-createsloop-body-application-json-settings-preventinitialbackfill
I've not done any Terraform additions like this one, so there is a good chance the syntax here is wrong — I see that this new setting likely needs to be added in a few additional places to make use of it after it's been added to the schema, so I'd appreciate guidance on where that needs to happen, exactly.
At any rate, it would be great to add this field, and as it's a new, optional field, it shouldn't have any breaking change consequences whatsoever.
UPDATE: I re-generated the SLO model files with openapi-generator, hoping it would only produce a small scope of changes in those files. It seems to have produced a LOT of changes, so I'll wait for guidance on how to handle that.